feat(redistribution): update slashers #492
Conversation
src/slashers/InstantSlasher.sol
Outdated
| operators[0] = _slashingParams.operator; | ||
| slashingRegistryCoordinator.updateOperators(operators); | ||
| _fulfillSlashingRequest(_slashingParams); | ||
| _updateOperatorStakeWeights(_slashingParams.operator); |
There was a problem hiding this comment.
Should we add a redistributable slasher which fulfills slash then redistributes?
There was a problem hiding this comment.
Not opposed, added _fulfillSlashingRequestAndBurnOrRedistribute already.
There was a problem hiding this comment.
+1 to yash's suggestion here
There was a problem hiding this comment.
I opted to add the internal _fulfillSlashingRequestAndBurnOrRedistribute method to the base. I don't think we should have an independent "Redistributable" Slasher that only calls this internal as its possible for it to fail and create a DoS scenario. If anything I think all slashers should expose both methods.
There was a problem hiding this comment.
But wouldn't AVSs want this is a key feature?
There was a problem hiding this comment.
Feel like its useful to have this in
| @@ -44,7 +44,7 @@ Creates and queues a new slashing request that will be executable after the veto | |||
| #### `cancelSlashingRequest` | |||
| ```solidity | |||
| function cancelSlashingRequest( | |||
| uint256 requestId | |||
| uint256 slashId | |||
There was a problem hiding this comment.
why rename the request to the slash here?
There was a problem hiding this comment.
Part of redistribution is each slash now has a slashId that's returned from slashOperator. So there's no longer a need to track requestIds in these slashers as its now duplicate storage.
0xClandestine
force-pushed
the
feat/slasher-updates
branch
from
4ecc5f8 to
716ebb3
Compare
|
Storage CI failing due to deprecating a variable. |
Motivation:
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications:
Describe the modifications you've done.
Result:
After your change, what will change.